tabeth commented on issue #1271: Add units to all stats
URL: https://github.com/apache/couchdb/issues/1271#issuecomment-584836884
 
 
   @wohali 
   OK. I'll take a look at the files and start trying to update the 
descriptions. 
   
   So for example (to make sure I'm doing this right):
   We have this:
   
   ```erlang
   {[dreyfus, index, search], [
       {type, histogram},
       {desc, <<"length of an dreyfus_index search request">>}
   ]}.
   ```
   
   Which seems to be implemented 
[here](https://github.com/apache/couchdb/blob/75e3acb426516e2ede8e70f55d72a73419cdeef3/src/dreyfus/src/dreyfus_index.erl#L57).
 `dreyfus_util:time/2` seems to call `timer:now_diff/2`, which returns 
microseconds. However it's divided by 1000, so the answer to the original 
question posed in the beginning should be *milliseconds*. 
   
   So our original example can be 
   ```erlang
   {[dreyfus, index, search], [
       {type, histogram},
       {desc, <<"length (in milliseconds) of an dreyfus_index search request">>}
   ]}.
   ```
   
   Is that right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to