iilyak commented on pull request #3110:
URL: https://github.com/apache/couchdb/pull/3110#issuecomment-683781092


   > @iilyak I changed my mind about moduletags, you were right, even if I'd 
prefer a moduletag in every test module.
   
   Sorry I was not clear. I am not against using moduletags. I was against 
changing existent ones. Your previous version of the PR had changes like 
`@moduletag :all_docs` -> `@moduletag :something_else`. I am totally fine with 
the following:
   
   ```
   @moduletag :all_docs
   @moduletag kind: :single_node
   ```
   
   After re-reading my following passage I do realize how confusing it sounds. 
Sorry about that.
   > Also I think we shouldn't change @moduletag but use @tag instead for 
tagging by setup. 
   
   The `moduletag` is better since it allows the developer to keep less things 
in mind when adding new tests. Again I am very sorry for having you changing it 
back and force.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to