[GitHub] [couchdb-nano] gyszalai opened a new issue #236: db.attachment.getAsStream method does not propagate axios errors to the caller

[GitBox]

gyszalai opened a new issue #236:
URL: https://github.com/apache/couchdb-nano/issues/236


   <!--- Provide a general summary of the issue in the Title above -->
   ## Expected Behavior
   If I call db.attachment.getAsStream() method and an axios error is thrown 
the caller should be notified.
   
   ## Current Behavior
   If I call e.g. db.attachment.getAsStream() with a non-existing document id, 
axios throws an error (404)
   The PassThrough instance that db.attachment.getAsStream() returns won't emit 
any events, so the caller
   will never receive the error, an unhandledPromiseRejection warning is raised 
instead.
   
   ## Possible Solution
   In case of an underlying axios error, the returned PassThrough instance 
should emit an `error` event.
   
   I inspected the corresponding code, nano.js line 343: 
https://github.com/apache/couchdb-nano/blob/b3f33b64d75bcd59f8cd9d2b9cd1f90d104b7e94/lib/nano.js#L343
   There should be a catch branch.
   
   ## Steps to Reproduce (for bugs)
   ```javascript
   const couchUrl = 'http://admin:admin@localhost:5984'
   const nano = require('nano')(couchUrl)
   const dbName = 'mydb'
   const db = nano.use(dbName)
   async function run () {
     console.log('start')
     await nano.db.destroy(dbName)
     console.log('db destroyed')
     await nano.db.create(dbName)
     console.log('db created')
   
     const docId = 'abc1234'
     const doc = { _id: docId, something: 'a' }
     const data = 'some attachment'
     const { rev } = await db.insert(doc)
     const attName = 'attName'
     console.log('inserting attachment')
     const response = await db.attachment.insert(docId, attName, 
Buffer.from(data, 'utf-8'), 'text/plain', { rev })
     console.log('attachment inserted', response)
   
     const attStream = await db.attachment.getAsStream(docId, attName)
     console.log('attachment stream returned')
     await new Promise((resolve, reject) => {
       attStream.on('data', () => console.log('data received:', data))
       attStream.on('end', resolve)
       attStream.on('error', reject)
     })
     console.log('attachment read OK')
     try {
       console.log('try reading attachment of a non-existing doc...')
       const attStream2 = await db.attachment.getAsStream('fake_doc_id', 
attName)
       console.log('attachment stream returned')
       await new Promise((resolve, reject) => {
         attStream2.on('data', () => console.log('data received: ', data))
         attStream2.on('end', resolve)
         attStream2.on('error', reject)
       })
     } catch (e) {
       console.log('error', e.message)
     }
   }
   
   run()
   ```
   ## Context
   I am trying to create an internal API for reading and writing documents and 
their attachments.
   
   ## Your Environment
   * Version used: 9.0.1
   * Browser Name and version: -
   * Operating System and version (desktop or mobile): macOS 10.15.7
   * Link to your project:
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org