glynnbird opened a new pull request #245:
URL: https://github.com/apache/couchdb-nano/pull/245


   ## Overview
   
   In Nano 8, supplying `{jar: true}` when starting up Nano forced the 
`request` library to parse, store and replay cookies which made the `auth` 
endpoint work correctly. In Nano 9, the axios library has no built-in cookie 
support so this PR fixes that by adding a couple of dependencies and using them 
when the `{jar: true}` parameter is set.
   
   Thanks to @robman87 for pointing this out. [His 
PR](https://github.com/apache/couchdb-nano/pull/242) was simpler but I opted 
for a "proper" cookie parser because folks use CouchDB in a lot of different 
ways and they may want their library/client to correctly 
interpret/parse/invalidate other cookies correctly too - not just the CouchDB 
authentication session cookie.
   ## Related Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those pull requests here.  -->
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [x] Documentation reflects the changes;
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to