byronmurg opened a new pull request #246:
URL: https://github.com/apache/couchdb-nano/pull/246


   ## Overview
   
   When calling an *AsStream method a client needs to handle errors
   raised by couch. These errors can include retrieving an attachment
   that doesn't exist or querying a deleted view.
   
   ## Testing recommendations
   
   The easiest way to test is to try retrieving an attachment that doesn't 
exist.
   
   e.g.
   ```
   alice.attachment.getAsStream('rabbit', 'doesntexist.png')
     .on('error', (e) => console.error(e))
     .pipe(/* handle stream */)
   ```
   
   ## GitHub issue number
   
   Fixes issue #236.
   
   There are likely other issues that are affected by this, but 236 is the most 
recent.
   
   ## Related Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those pull requests here.  -->
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [x] Documentation reflects the changes;
   
   The material changes are covered by the tests however I am unable to get 
nock errors to emit with isAxiosError.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to