nickva edited a comment on pull request #3363: URL: https://github.com/apache/couchdb/pull/3363#issuecomment-776124292
@janosgyerman Very nice. It's good to have friendly error message and send stack traces to the logs. I wonder if on `main` the specific `EXIT` clause error won't even apply. We'd have to call a `gen_server` from the request process and then the callback inside would throw an `error` and I couldn't remember if there are any calls to gen_servers made from the request process. Also, what do the logs show with and without your fix on 3.x, would you mind sharing those? And then perhaps move the PR to the 3.x branch. On main we'd have to see if these types of stacktraces can be generated at all. Maybe we'd need to other clauses here not just 'EXIT'. As a fun experiment to help generate error you could insert various `error(some_message)` or `exit(exit_message)` expression in lower level functions which read or write to FDB (something in fabric2_db, fabric2_fdb, erlfdb, maybe). To make it fancy you could make them a bit random and say something like: `case random:uniform() < 0.1 of true -> exit(boom); false -> ok end.` so only 10% of the time you'd get the error. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
