nickva opened a new pull request #3414:
URL: https://github.com/apache/couchdb/pull/3414


   It turns out fabric is dependent on couch_jobs because of db expiration 
module.
   So when couch_jobs was restarted multiple times per test case it could have
   brought down fabric. However, since couch_jobs needs fabric for transactional
   stuff it ended up brining couch_jobs app down as well.
   
   To fix it:
   
    * Switch to explicitly starting/stopping fabric and couch_jobs together
   
    * Break apart bad_messages* tests to individually test each type of message
      as app restarts in the middle of the tests kept killing fabric and
      intermittently killing couch_jobs a well.
   
    * Also make the tests look nicer by re-using ?TDEF_FE macros from
      `fabric2_test`, this we can avoid the `?_test(begin... end).` pattern.
   
    * Remove `meck:unload` since we don't really `meck` anything in the module
   
    * Don't need to spend time cleaning out database as we don't really create
      that many dbs (just one) and that one gets cleaned out in its own test.
   
   To test run:
   
   ```
     make eunit apps=couch_jobs
   ```
   
   Or just observer the jenkins CI tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to