janl commented on pull request #3421: URL: https://github.com/apache/couchdb/pull/3421#issuecomment-798771152
Thank you @hotsphink and @evilpie for the extremely thorough review! ππββοΈπ I appreciate you taking the time to go through all this! The main bulk of this code is pasted from `../68.` which we have working fine in production (not saying it canβt be improved :) Weβll need a few more eyes on this to see how we can integrate those improvements as my C++ chop pretty much end at making function calls align as in the OP diff (which are the changes I really did, aside from the build system additions). I hope @jiangphcn @davisp @wohali can have a look. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
