janl edited a comment on issue #3115: URL: https://github.com/apache/couchdb/issues/3115#issuecomment-798669543
I’ve started digging through these. - [x] fixing `-Ilerl_interface` is relatively easy, we are not using it anywhere, so we can just hotwire our local rebar copy: https://github.com/apache/couchdb-rebar/pull/2 ```diff diff --git a/src/rebar_port_compiler.erl b/src/rebar_port_compiler.erl index 9679c80..44f7b0d 100644 --- a/src/rebar_port_compiler.erl +++ b/src/rebar_port_compiler.erl @@ -673,7 +673,7 @@ default_env() -> "\" " ])}, {"ERL_EI_LIBDIR", lists:concat(["\"", erl_interface_dir(lib), "\""])}, - {"ERL_LDFLAGS" , " -L$ERL_EI_LIBDIR -lerl_interface -lei"}, + {"ERL_LDFLAGS" , " -L$ERL_EI_LIBDIR -lei"}, {"ERLANG_ARCH" , rebar_utils:wordsize()}, {"ERLANG_TARGET", rebar_utils:get_arch()}, ``` - [x] `get_stacktrace()` is not getting removed until 24, so we have one more release to go, but the diff is totally bearable IMHO: https://github.com/apache/couchdb/pull/new/feat/3.x/otp23 - [x] snappy needs to allow 23 https://github.com/apache/couchdb-snappy/pull/12 ```diff diff --git a/rebar.config b/rebar.config index 1785295..250cd2a 100644 --- a/rebar.config +++ b/rebar.config @@ -1,4 +1,4 @@ -{require_otp_vsn, "R14|R15|R16|17|18|19|20|21|22"}. +{require_otp_vsn, "R14|R15|R16|17|18|19|20|21|22|23"}. {erl_opts, [debug_info, warn_unused_vars, warn_shadow_vars, warn_unused_import]}. {port_sources, ["c_src/*.cc", ``` - [x] jiffy needs… ~I don’t know ;D @davisp help:~ h/t @rnewson jiffy `main` already supports 23, — That’s as far as I got this time around. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
