bessbd commented on pull request #3490: URL: https://github.com/apache/couchdb/pull/3490#issuecomment-813563345
> I left a more complete response in [#3488 (comment)](https://github.com/apache/couchdb/pull/3488#issuecomment-812723151) but the idea is it's a bit more general and works along the lines of how current libicu version does (treating `FFFF `as special), so when we stop supporting CentOS 7 we can remove just that one max handling section and let libicu do the right thing. I still don't get why (lower level) C code should be aware of a specific higher level (marker) constant (in erlang - caller code). - https://github.com/apache/couchdb/pull/3490/files#diff-e07aa2cf62bca24d714bb7b5d125f77a906db4145a60672e532e27a324b7dcf7R69-R73 . Sounds like a Separation of concerns violation. Nevertheless, I'm confident that we're better of this PR merged than without. +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
