nickva commented on pull request #3208:
URL: https://github.com/apache/couchdb/pull/3208#issuecomment-833021619


   Based on what ibrowse author had 
[mentioned](https://github.com/cmullaparthi/ibrowse/issues/146#issuecomment-241578585)
 `terminate/2` should be called. But that happens only if the parent [1] 
process dies not any linked process.  In our (CouchDB) case, we simply link to 
worker when we check it out from the pool so this link is not a "parent" link 
so that means `terminate/2` won't be called and the ibrowse worker won't stop.
   
   [1] A parent in OTP terminology is indicated by a [pdict entry]( 
https://github.com/erlang/otp/blob/master/lib/stdlib/src/gen.erl#L481-L489). 
And the code to call `terminate/2` only when receiving `'EXIT'` from parents is 
https://github.com/erlang/otp/blob/master/lib/stdlib/src/gen_server.erl#L480-L481
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to