nickva commented on a change in pull request #3553:
URL: https://github.com/apache/couchdb/pull/3553#discussion_r632074634
##########
File path: src/couch_views/test/couch_views_indexer_test.erl
##########
@@ -610,6 +613,23 @@ index_can_recover_from_crash(Db) ->
], Out).
+handle_acquire_map_context_error(_) ->
+ meck:new(mock_language_server, [non_strict]),
+ config:set("couch_eval.languages", ?QUERY_SERVER_LANG_STRING,
+ atom_to_list(mock_language_server)),
+ meck:expect(mock_language_server, acquire_map_context,
+ fun(_) -> {error, foo_error} end),
+ {'EXIT', {Reason, _}} = (catch
couch_views_indexer:start_query_server(#mrst{
Review comment:
I think `?assertError(foo_error, ` might work better here.
Also as is, I think the line is longer than 80 columns. Could pull `Mrst =
#mrst{` into its own variable so it would fit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
