nickva commented on a change in pull request #6:
URL: https://github.com/apache/couchdb-ibrowse/pull/6#discussion_r638984836
##########
File path: src/ibrowse.erl
##########
@@ -159,7 +159,7 @@ stop() ->
%% headerName() = string()
%% headerValue() = string()
%% response() = {ok, Status, ResponseHeaders, ResponseBody} | {ibrowse_req_id,
req_id() } | {error, Reason}
-%% req_id() = term()
+%% req_id() = {MegaSecs::integer >= 0, Secs::integer >= 0, Unique::integer >=
0}
Review comment:
Let's keep this unspecified as a term. Yeah some users might have relied
on it being a timestamp or might have matched {_, _, }, or adding some log
parsing based on it. But we don't necessarily want to promise this to be a
format in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
