bessbd commented on a change in pull request #3568: URL: https://github.com/apache/couchdb/pull/3568#discussion_r643941867
########## File path: dev/format_check.py ########## @@ -0,0 +1,59 @@ +#!/usr/bin/env python3 +# +# Licensed under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. + +"""Erlang formatter for CouchDB +Warning: this file needs to run from the CouchDB repo root. +USAGE: ERLFMT_PATH=<path_to_erlfmt> python3 dev/format_check.py +""" + +import os +import subprocess +import sys + +from format_lib import get_source_paths + +FILTERED_LINES = [ + 'Checking formatting...', + '[warn] Code style issues found in the above file(s). Forgot to run erlfmt?', + '' +] + +if __name__ == "__main__": + os.chdir('src') + failed_checks = 0 + for item in get_source_paths(): + if item['is_source_path']: + run_result = subprocess.run([ + os.environ["ERLFMT_PATH"], + '-c', + '--verbose', + # We have some long lines and erlfmt doesn't forcefully wrap + # them all. We should decrease this over time + '--print-width=167', + item['raw_path'] + ], encoding="utf-8", capture_output=True + ) Review comment: Done in db881f6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
