nickva commented on a change in pull request #659:
URL: 
https://github.com/apache/couchdb-documentation/pull/659#discussion_r645272477



##########
File path: src/whatsnew/1.4.rst
##########
@@ -48,7 +48,7 @@ Version 1.4.0
   updates and deletion of databases. :commit:`917d8988`
 * :issue:`1772`: Prevent invalid JSON output when using `all_or_nothing`
   :ref:`of bulk API <api/db/bulk_docs>`. :commit:`dfd39d57`
-* Add a :config:option:`configurable whitelist 
<couch_httpd_auth/public_fields>`
+* Add a :config:option:`configurable whitelist <chttpd_auth/public_fields>`

Review comment:
       We don't want to modify whatsnew/1.4 since the release is already out

##########
File path: src/whatsnew/2.1.rst
##########
@@ -53,7 +53,7 @@ Upgrade Notes
   ``stale=update_after`` behaviour is equivalent to 
``stable=true&update=lazy``.
   The deprecated ``stale`` parameter will be removed in CouchDB 3.0.
 
-* The new :config:option:`httpd/max_http_request_size` configuration parameter
+* The new :config:option:`chttpd/max_http_request_size` configuration parameter

Review comment:
       Let's not modify 2.1 release

##########
File path: src/whatsnew/3.2.rst
##########
@@ -0,0 +1,55 @@
+.. Licensed under the Apache License, Version 2.0 (the "License"); you may not
+.. use this file except in compliance with the License. You may obtain a copy 
of
+.. the License at
+..
+..   http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+.. WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+.. License for the specific language governing permissions and limitations 
under
+.. the License.
+
+.. _release/3.2.x:
+
+============
+3.2.x Branch
+============
+
+.. contents::
+    :depth: 1
+    :local:
+
+.. _release/3.2.0:
+
+Version 3.2.0
+=============
+
+Features and Enhancements
+-------------------------
+
+* :ghissue:`3472`, :ghissue:`3473`: Migrate some config options from [httpd]
+  to [chttpd], migrate some from [couch_httpd_auth] to [chttpd_auth], and
+  commented out in the default.ini.
+
+  **Moved config options from [httpd] to [chttpd]:**
+  `allow_jsonp`, `changes_timeout`, `config_whitelist`,
+  `enable_cors`, `secure_rewrites`, `x_forwarded_host`,
+  `x_forwarded_proto`, `x_forwarded_ssl`,
+  `enable_xframe_options`, `max_http_request_size`.
+
+  **Moved config options from [couch_httpd_auth] to [chttpd_auth]:**
+  `authentication_redirect`, `require_valid_user`, `timeout`, 
`auth_cache_size`,
+  `allow_persistent_cookies`, `iterations`, `min_iterations`, `max_iterations`,
+  `password_scheme`, `proxy_use_secret`, `public_fields`, `secret`,
+  `users_db_public`, `x_auth_roles`, `x_auth_token`, `x_auth_username`,
+  `cookie_domain`, `same_site`
+
+Features and Enhancements
+-------------------------
+
+* :ghissue:`3586`: We added a new way of specifying basic auth credentials
+  which can include various characters previously not allowed to be included
+  in the url info part of endpoint urls.
+
+* Thank you for reading.

Review comment:
       Let's just add this issue to the previous Features and Enhancements 
section instead of making a new section

##########
File path: src/whatsnew/3.2.rst
##########
@@ -0,0 +1,55 @@
+.. Licensed under the Apache License, Version 2.0 (the "License"); you may not
+.. use this file except in compliance with the License. You may obtain a copy 
of
+.. the License at
+..
+..   http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+.. WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+.. License for the specific language governing permissions and limitations 
under
+.. the License.
+
+.. _release/3.2.x:
+
+============
+3.2.x Branch
+============
+
+.. contents::
+    :depth: 1
+    :local:
+
+.. _release/3.2.0:
+
+Version 3.2.0
+=============
+
+Features and Enhancements
+-------------------------
+
+* :ghissue:`3472`, :ghissue:`3473`: Migrate some config options from [httpd]
+  to [chttpd], migrate some from [couch_httpd_auth] to [chttpd_auth], and
+  commented out in the default.ini.
+
+  **Moved config options from [httpd] to [chttpd]:**
+  `allow_jsonp`, `changes_timeout`, `config_whitelist`,
+  `enable_cors`, `secure_rewrites`, `x_forwarded_host`,
+  `x_forwarded_proto`, `x_forwarded_ssl`,
+  `enable_xframe_options`, `max_http_request_size`.
+
+  **Moved config options from [couch_httpd_auth] to [chttpd_auth]:**
+  `authentication_redirect`, `require_valid_user`, `timeout`, 
`auth_cache_size`,
+  `allow_persistent_cookies`, `iterations`, `min_iterations`, `max_iterations`,
+  `password_scheme`, `proxy_use_secret`, `public_fields`, `secret`,
+  `users_db_public`, `x_auth_roles`, `x_auth_token`, `x_auth_username`,
+  `cookie_domain`, `same_site`
+
+Features and Enhancements
+-------------------------
+
+* :ghissue:`3586`: We added a new way of specifying basic auth credentials

Review comment:
       Let's just add this issue to the previous Features and Enhancements 
section instead of making a new section

##########
File path: src/whatsnew/1.4.rst
##########
@@ -48,7 +48,7 @@ Version 1.4.0
   updates and deletion of databases. :commit:`917d8988`
 * :issue:`1772`: Prevent invalid JSON output when using `all_or_nothing`
   :ref:`of bulk API <api/db/bulk_docs>`. :commit:`dfd39d57`
-* Add a :config:option:`configurable whitelist 
<couch_httpd_auth/public_fields>`
+* Add a :config:option:`configurable whitelist <chttpd_auth/public_fields>`

Review comment:
       Hmm, in that case we should turn the link into a regular string perhaps?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to