jimfcarroll opened a new pull request #51:
URL: https://github.com/apache/couchdb-helm/pull/51


   <!--
   Thank you for contributing to couchdb-helm. Before you submit this PR we'd 
like to
   make sure you are aware of the chart technical requirements and best 
practices:
   
   * 
https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements
   * https://github.com/helm/helm/tree/master/docs/chart_best_practices
   
   For a quick overview across what we will look at reviewing your PR, please 
read
   our review guidelines:
   
   * https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md
   
   Following our best practices right from the start will accelerate the review 
process and
   help get your PR merged quicker.
   
   When updates to your PR are requested, please add new commits and do not 
squash the
   history. This will make it easier to identify new changes. The PR will be 
squashed
   anyways when it is merged. Thanks.
   
   Please make sure you test your changes before you push them.
   -->
   
   #### What this PR does / why we need `it:`
   
   `make test` currently fails on a new install because the `apiVersion` is no 
longer supported (at least with the latest install of `kind`).  Once the 
`apiVersion` is fixed, there's a linting error picked up by the test in 
`couchdb/values.yaml` because there's a blank line with several spaces (see the 
diff).
   
   #### Which issue this PR fixes
   *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, 
will close that issue when PR gets merged)*
     - fixes #
   
   #### Special notes for your reviewer:
   Each of the two minor changes is in a separate and logged commit. I can 
squash of course.
   
   #### Checklist
   [Place an '[x]' (no spaces) in all applicable fields. Please remove 
unrelated fields.
   - [ ] Chart Version bumped
   - [x] e2e tests pass
   - [ ] Variables are documented in the README.md
   - [ ] Chart tgz added to /docs and index updated
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to