nickva commented on a change in pull request #3724:
URL: https://github.com/apache/couchdb/pull/3724#discussion_r701464753
##########
File path: src/chttpd/test/eunit/chttpd_db_test.erl
##########
@@ -209,6 +211,49 @@ should_return_200_for_del_att_with_rev(Url) ->
end)}.
+should_send_csp_header_with_att(Url) ->
+ {timeout, ?TIMEOUT, ?_test(begin
+ {ok, RC, _, _} = test_request:put(
+ Url ++ "/testdoc5",
+ [?CONTENT_JSON, ?AUTH],
+ jiffy:encode(attachment_doc())
+ ),
+ ?assertEqual(201, RC),
+
+ {ok, _, Headers, _} = test_request:get(
+ Url ++ "/testdoc5/file.erl",
+ [?AUTH],
+ []
+ ),
+ CSPHeader = couch_util:get_value("Content-Security-Policy", Headers),
+ ?assertEqual("sandbox", CSPHeader)
+ end)}.
+
+
+should_send_not_csp_header_with_att_when_no_config(Url) ->
+ {timeout, ?TIMEOUT, ?_test(begin
+ {ok, RC, _, _} = test_request:put(
+ Url ++ "/testdoc6",
+ [?CONTENT_JSON, ?AUTH],
+ jiffy:encode(attachment_doc())
+ ),
+ ?assertEqual(201, RC),
+
+ config:set_boolean("csp", "attachments_enable", false),
+
+ {ok, _, Headers, _} = test_request:get(
+ Url ++ "/testdoc6/file.erl",
+ [?AUTH],
+ []
+ ),
+ CSPHeader = couch_util:get_value("Content-Security-Policy", Headers),
+ ?assertEqual(undefined, CSPHeader),
+
+ config:set_boolean("attachments", "csp_enable", true)
Review comment:
I think the sections got mixed here.
Also, if is use `_Persist=false` above we'd delete the value and it should
return to defaults:
`config:delete("csp", "attachments_enable", _Persist=false)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
