nickva opened a new pull request #3746: URL: https://github.com/apache/couchdb/pull/3746
couch_icu_driver is only used for binary strings comparison in couch_ejson_compare when expression depth becomes greater than 10. The logic for the comparison is identical to what couch_ejson_compare uses, so opt to just use couch_ejson_compare only, instead of keeping a whole other binary collation driver around. To avoid a possible infinite loop if couch_ejson_compare NIF fails to load, throw a nif loading error as is common for NIF modules. To avoid another case of a possible infinite retry from of badarg generated from by max depth, and an actual bad ejson term, use a specific max depth error so we don't have to guess when we catch it and retry term traversal in erlang. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
