nickva commented on a change in pull request #3764:
URL: https://github.com/apache/couchdb/pull/3764#discussion_r715652735
##########
File path: src/chttpd/src/chttpd_changes.erl
##########
@@ -604,31 +605,49 @@ keep_sending_changes(Args, Acc0, FirstRound) ->
true ->
case wait_updated(Timeout, TimeoutFun, UserAcc3) of
{updated, UserAcc4} ->
- UserCtx = fabric2_db:get_user_ctx(Db),
- DbOptions1 = [{user_ctx, UserCtx} | DbOptions],
- case fabric2_db:open(fabric2_db:name(Db),
DbOptions1) of
- {ok, Db2} ->
- ?MODULE:keep_sending_changes(
- Args#changes_args{limit = NewLimit},
- ChangesAcc#changes_acc{
- db = Db2,
- user_acc = UserAcc4,
- seq = EndSeq,
- prepend = Prepend2,
- timeout = Timeout,
- timeout_fun = TimeoutFun
- },
- false
- );
- _Else ->
- end_sending_changes(Callback, UserAcc3,
EndSeq)
+ AccumulatedTime = timer:now_diff(os:timestamp(),
T0) div 1000,
Review comment:
To avoid the `div 1000` could use the more modern (OTP 18+) time
functions here:
```
1> erlang:system_time(millisecond).
1632492974842
2> T0 = erlang:system_time(millisecond), timer:sleep(1000),
erlang:system_time(millisecond) - T0.
1000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
