tonysun83 commented on a change in pull request #3780:
URL: https://github.com/apache/couchdb/pull/3780#discussion_r725257375
##########
File path: src/couch/src/couch_db.erl
##########
@@ -2047,6 +2051,18 @@ t_calculate_start_seq_epoch_mismatch() ->
?assertEqual(0, Seq)
end).
+t_calculate_start_seq_shard_move() ->
+ ?_test(begin
+ Db = test_util:fake_db([]),
+ % Sequence when shard was on node1
+ ?assertEqual(2, calculate_start_seq(Db, node1, {2, <<"foo">>})),
+ % Sequence from node1 after the move happened, we reset back to the
+ % start of the epoch on node2 = 10
+ ?assertEqual(10, calculate_start_seq(Db, node1, {16, <<"foo">>})),
Review comment:
Trying to think if this ever happens and if it's the right result:
```
?assertEqual(10, calculate_start_seq(Db, node1, {8, <<"foo">>})),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
