Antonio-Maranhao commented on a change in pull request #1331:
URL: https://github.com/apache/couchdb-fauxton/pull/1331#discussion_r788073586
##########
File path: app/addons/documents/rev-browser/components/splitscreenarea.js
##########
@@ -12,16 +12,13 @@
import React from 'react';
import ReactDOM from "react-dom";
-import ace from "brace";
-require('brace/ext/static_highlight');
-const highlight = ace.acequire('ace/ext/static_highlight');
+const highlight =
require('ace-builds/src-min-noconflict/ext-static_highlight');
-require('brace/mode/json');
-const JavaScriptMode = ace.acequire('ace/mode/json').Mode;
+require('ace-builds/src-min-noconflict/mode-json');
+const JavaScriptMode =
require('ace-builds/src-min-noconflict/mode-javascript').Mode;
Review comment:
I noticed syntax highlighting was a bit different in the rev-browser,
and it's because the mode here is wrong. It should be `mode-json`.
Please fix the var name as well.
##########
File path: app/addons/components/components/zenmodeoverlay.js
##########
@@ -15,7 +15,7 @@ import app from "../../../app";
import {CodeEditor} from './codeeditor';
import {Tooltip, OverlayTrigger} from 'react-bootstrap';
-require('brace/theme/dawn');
+require('ace-builds/src-min-noconflict/theme-dawn');
Review comment:
Dawn theme was not getting applied. I had to add `import
'ace-builds/css/theme/dawn.css';` here to make it work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
