Antonio-Maranhao opened a new pull request #1333:
URL: https://github.com/apache/couchdb-fauxton/pull/1333
## Overview
When the permanent notification banner is displayed, the browser shows a
vertical scroll bar for the whole page.
This happens because the banner is located outside the App `<div>`, which is
is set to 100% height.
Therefore, the total height becomes 100% + banner height, hence the
scrollbar showing.
This PR adjusts the height of the App `<div>` when the permanent
notification is visible.
## Testing recommendations
Call `Fauxton.showPermanentNotification("a msg here");` and verify the
vertical scrollbar doesn't appear.
## GitHub issue number
n/a
## Related Pull Requests
n/a
## Checklist
- [x] Code is written and works correctly;
- [ ] Changes are covered by tests;
- [ ] Documentation reflects the changes;
- [ ] Update
[rebar.config.script](https://github.com/apache/couchdb/blob/main/rebar.config.script)
with the correct tag once a new Fauxton release is made
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
