iilyak commented on a change in pull request #3766:
URL: https://github.com/apache/couchdb/pull/3766#discussion_r815855613
##########
File path: src/smoosh/src/smoosh_channel.erl
##########
@@ -16,27 +16,39 @@
-include_lib("couch/include/couch_db.hrl").
% public api.
--export([start_link/1, close/1, suspend/1, resume/1, get_status/1]).
--export([enqueue/3, last_updated/2, flush/1]).
+-export([start_link/1, close/1, suspend/1, resume/1, activate/1,
get_status/1]).
+-export([enqueue/3, last_updated/2, flush/1, is_key/2, is_activated/1,
persist/1]).
% gen_server api.
-export([
init/1,
handle_call/3,
handle_cast/2,
handle_info/2,
- code_change/3,
terminate/2
]).
+-define(VSN, 1).
+-define(CHECKPOINT_INTERVAL_IN_MSEC, 180000).
+
+-ifndef(TEST).
+-define(START_DELAY_IN_MSEC, 60000).
+-define(ACTIVATE_DELAY_IN_MSEC, 30000).
+-else.
+-define(START_DELAY_IN_MSEC, 0).
+-define(ACTIVATE_DELAY_IN_MSEC, 0).
+-endif.
+
Review comment:
Adding FSM diagram here (using
http://mermaid-js.github.io/mermaid/#/stateDiagram syntax) would also help.
don't bother with `choice` directives. Just basic transitions with description
of a transition.
```
S1 --> S2 : BlaBlaBla
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
