nickva edited a comment on issue #3948: URL: https://github.com/apache/couchdb/issues/3948#issuecomment-1069187996
@tonysun83 yeah, we could mimic the `couch_util:get_value(Key, SortedResults)` => `undefined` for missing entries, but I wonder if we should double-check how we end up in this state. I wonder if it's because we got a bunch of `rexi_DOWN` or `rexi_EXIT` and called `skip_message` https://github.com/apache/couchdb/blob/e4b8a4624fc7ae09b4649aac9a8d68226208cd8b/src/fabric/src/fabric_doc_update.erl#L62-L74 In general for `undefined`, we should probably emit a `missing_response` or `internal_server_error`. It's interesting what our guarantees are with respect to what return code we emit then, should it be a 201/202 even if we didn't get any results for some docs... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
