noahshaw11 opened a new pull request, #4093:
URL: https://github.com/apache/couchdb/pull/4093

   ## Overview
   
   Currently, no error is written to logs when smoosh fails to write its state 
to the filesystem. This PR writes the error to the logs.
   Note: We do not want smoosh crash with an error since failing to persist the 
queue should not interfere with smoosh operations. Furthermore, nested case 
statements were used because we do not wish to continue on to the next step in 
writing the state to the filesystem if we encounter an error.
   
   ## Testing recommendations
   
   ## Related Issues or Pull Requests
   
   Add smoosh queue persistence: https://github.com/apache/couchdb/pull/3766
   
   ## Checklist
   
   - [ ] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in 
`rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in 
https://github.com/apache/couchdb-documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to