zachlankton opened a new pull request, #4146:
URL: https://github.com/apache/couchdb/pull/4146
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from
committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
This PR is to bring the `devconatiner` in this repo up to date and improve
its reliability. The current config uses outdated dependencies and does not
work out of the box.
Here are the updates:
- Use volume mount instead of bind to improve performance and help solve
#4145
- Updated `README` and `README-DEV` to include quick buttons/links to spin
up devcontainer
- Automatically run `./configure && make` during container creation
## Testing performed to validate dev container...
Click the button below to automatically spin up a devcontainer on your local
machine.
(this demo button uses
[zachlankton/couchdb-test](https://github.com/zachlankton/couchdb-test) repo to
show how the button will work once this PR is merged into main)
[](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/zachlankton/couchdb-test)
Once the container is finished setting up (will take some time due to
automatically running `./configure && make` run the following commands to
verify everything works:
```bash
./dev/run
# login to http://localhost:15984/_utils/
# make a db and some docs
# run the "Verify Install"
# CTRL-C when you are satisfied
# then run
make check
# all test should pass!
```
## Checklist
- [X] Code is written and works correctly
- [n/a] Changes are covered by tests
- [n/a] Any new configurable parameters are documented in
`rel/overlay/etc/default.ini`
- [n/a] A PR for documentation changes has been made in
https://github.com/apache/couchdb-documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]