nickva opened a new pull request, #4151: URL: https://github.com/apache/couchdb/pull/4151
The main goal is to test the clustered (chttpd/fabric) endpoints instead of the local (backend) versions. This is a more realistic test scenario since that's the API used most often in practice. Besides switching to chttpd and fabric, also remove the extra cruft left from when we had `local` and `remote` test flavors. After a previous refactoring only the `remote` version remained, but a lot of scaffolding in the form of a parameterized `foreachx` test generators was left behind. Also, the majority of replication tests were using a similar set of setup and teardown functions, so those were moved to the common test helper module. Almost all test modules benefited from the removal of the `?_test(begin...end)` construct and switched to using the `TDEF_FE` macro which makes the test definition and implementation of tests easier to read and saves an indentation level, which is always nice to have. To make it easier to review, the PR is structured as a bunch of smaller individual commits - one per test module, starting with test helpers in `couch_replicator_test_helper`. Each test module then has its own commit with comments summarizing the changes. Another note for the reviewer is that all the changes are only in the `test/eunit` subfolder and no `src` modules were altered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
