iilyak commented on code in PR #4151:
URL: https://github.com/apache/couchdb/pull/4151#discussion_r950279894
##########
src/couch_replicator/test/eunit/couch_replicator_test_helper.erl:
##########
@@ -4,39 +4,73 @@
-include_lib("couch/include/couch_db.hrl").
-include_lib("couch_replicator/src/couch_replicator.hrl").
+-define(USERNAME, "rep_test_user").
+-define(PASSWORD, "rep_test_pass").
+
-export([
- compare_dbs/2,
- compare_dbs/3,
- db_url/1,
+ cluster_compare_dbs/2,
+ cluster_compare_dbs/3,
+ cluster_doc_revs/1,
+ cluster_open_rev/3,
+ cluster_url/0,
+ cluster_db_url/1,
replicate/1,
get_pid/1,
- replicate/2
+ replicate/2,
+ test_setup/0,
+ test_teardown/1,
+ setup_db/0,
+ teardown_db/1
]).
-compare_dbs(Source, Target) ->
- compare_dbs(Source, Target, []).
-
-compare_dbs(Source, Target, ExceptIds) ->
- {ok, SourceDb} = couch_db:open_int(Source, []),
- {ok, TargetDb} = couch_db:open_int(Target, []),
-
- Fun = fun(FullDocInfo, Acc) ->
- {ok, DocSource} = couch_db:open_doc(SourceDb, FullDocInfo),
- Id = DocSource#doc.id,
- case lists:member(Id, ExceptIds) of
- true ->
- ?assertEqual(not_found, couch_db:get_doc_info(TargetDb, Id));
- false ->
- {ok, TDoc} = couch_db:open_doc(TargetDb, Id),
- compare_docs(DocSource, TDoc)
+cluster_compare_dbs(Source, Target) ->
+ cluster_compare_dbs(Source, Target, []).
+
+cluster_compare_dbs(Source, Target, ExceptIds) ->
+ ?assertMatch({ok, [_ | _]}, fabric:get_db_info(Source)),
+ ?assertMatch({ok, [_ | _]}, fabric:get_db_info(Target)),
+ lists:foreach(
+ fun({Id, Rev}) ->
+ SrcDoc = cluster_open_rev(Source, Id, Rev),
+ TgtDoc = cluster_open_rev(Target, Id, Rev),
+ case lists:member(Id, ExceptIds) of
+ true ->
+ ?assertEqual(not_found, TgtDoc);
+ false ->
+ compare_docs(SrcDoc, TgtDoc)
+ end
end,
- {ok, Acc}
- end,
+ cluster_doc_revs(Source)
+ ).
+
+cluster_open_rev(DbName, Id, Rev) ->
+ {ok, [Result]} = fabric:open_revs(DbName, Id, [Rev], []),
+ case Result of
+ {ok, #doc{} = Doc} ->
+ Doc;
+ {{not_found, missing}, _} ->
+ not_found
+ end.
+
+cluster_doc_revs(DbName) ->
+ Opts = [{style, all_docs}],
+ {ok, Acc} = fabric_util:isolate(fun() ->
+ fabric:changes(DbName, fun changes_callback/2, [], Opts)
+ end),
+ Acc.
- {ok, _} = couch_db:fold_docs(SourceDb, Fun, [], []),
- ok = couch_db:close(SourceDb),
- ok = couch_db:close(TargetDb).
+changes_callback(start, Acc) ->
Review Comment:
IRC there is also a `timeout` case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
