jaydoane commented on code in PR #4172: URL: https://github.com/apache/couchdb/pull/4172#discussion_r967681064
########## src/couch_replicator/test/eunit/couch_replicator_bulk_get_tests.erl: ########## @@ -0,0 +1,74 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); you may not +% use this file except in compliance with the License. You may obtain a copy of +% the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, software +% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +% License for the specific language governing permissions and limitations under +% the License. + +-module(couch_replicator_bulk_get_tests). + +-include_lib("couch/include/couch_eunit.hrl"). +-include_lib("couch/include/couch_db.hrl"). +-include("couch_replicator_test.hrl"). + +-define(DOCS, 10). Review Comment: Might be clearer as `DOC_COUNT`? ########## rel/overlay/etc/default.ini: ########## @@ -494,6 +494,8 @@ partitioned||* = true ;retries_per_request = 5 ; Use checkpoints ;use_checkpoints = true +; Attempt to use bulk_get for fetching documents from the source +;use_bulk_get = true Review Comment: I suppose another approach would be to change the default to `false` for now to keep existing behavior, but switch it to `true` for a major version change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
