davisp commented on PR #4264: URL: https://github.com/apache/couchdb/pull/4264#issuecomment-1314032505
Ignore everything I said earlier because I wasn't paying attention enough to realize that the internal nodes not being counted was for key trees, not b trees. This looks right to me in that we shouldn't be counting the size of the deleted internal nodes of a revision tree. The change in the docs/active size definition should go from something like "The approximate number of bytes to represent this database after compaction" which is slightly different than "The number of active bytes reachable from root" because we're purposefully ignoring bytes we can get to that will no longer exist after compaction. And that doc change is only if we don't definite it as such already. Good work and sorry for the Monday morning noise! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
