jaydoane opened a new pull request, #4268:
URL: https://github.com/apache/couchdb/pull/4268
## Overview
<!-- Please give a short brief for the pull request,
what problem it solves or how it makes things better. -->
This test can time out with the following stack trace because [ibrowse sends
{error, retry_later} under certain conditions](url) [1] which causes
test_request:request/6 to sleep and retry [2], which can result in this failure:
```
chttpd_dbs_info_test:79: -dbs_info_test_/0-fun-20-
(should_return_500_time_out_when_time_is_not_enough_for_get_dbs_info)...*timed
out*
in function timer:sleep/1 (timer.erl, line 219)
in call from test_request:request/6 (src/test_request.erl, line 106) in call
from
chttpd_dbs_info_test:should_return_500_time_out_when_time_is_not_enough_for_get_dbs_info/1
(test/eunit/chttpd_dbs_info_test.erl, line 157) in call from
eunit_test:run_testfun/1 (eunit_test.erl, line 71) in call from
eunit_proc:run_test/1 (eunit_proc.erl, line 531) in call from
eunit_proc:with_timeout/3 (eunit_proc.erl, line 356) in call from
eunit_proc:handle_test/2 (eunit_proc.erl, line 514) in call from
eunit_proc:tests_inorder/3 (eunit_proc.erl, line 456)
undefined
```
[1]
https://github.com/cmullaparthi/ibrowse/blob/22d6fd6baa6e83633aa2923f41589945c1d2dc2f/src/ibrowse.erl#L409
[2]
https://github.com/apache/couchdb/blob/62d92766e8b8042c2f3627c3ac3e2365410c7912/src/couch/src/test_request.erl#L104-L106
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from
committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Testing recommendations
```
make eunit apps=chttpd suites=chttpd_dbs_info_test tests=dbs_info_test_
```
<!-- Describe how we can test your changes.
Does it provides any behaviour that the end users
could notice? -->
## Related Issues or Pull Requests
<!-- If your changes affects multiple components in different
repositories please put links to those issues or pull requests here.
-->
## Checklist
- [x] Code is written and works correctly
- [x] Changes are covered by tests
- [ ] Any new configurable parameters are documented in
`rel/overlay/etc/default.ini`
- [ ] Documentation changes were made in the `src/docs` folder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
