yekibud opened a new pull request, #105:
URL: https://github.com/apache/couchdb-helm/pull/105

   <!--
   Thank you for contributing to couchdb-helm. Before you submit this PR we'd 
like to
   make sure you are aware of the chart technical requirements and best 
practices:
   
   * 
https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements
   * https://github.com/helm/helm/tree/master/docs/chart_best_practices
   
   For a quick overview across what we will look at reviewing your PR, please 
read
   our review guidelines:
   
   * https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md
   
   Following our best practices right from the start will accelerate the review 
process and
   help get your PR merged quicker.
   
   When updates to your PR are requested, please add new commits and do not 
squash the
   history. This will make it easier to identify new changes. The PR will be 
squashed
   anyways when it is merged. Thanks.
   
   Please make sure you test your changes before you push them.
   -->
   
   #### What this PR does / why we need it:
   Statefulset volumeClaimTemplates create new volumes and 
PersistentVolumeClaims which cannot be mutated.  This PR adds the ability to 
declare a persistentVolume as existing and provide the required PV and PVC data 
for binding a volume to the statefulset.  This is especially useful for 
restoring backup snapshots during disaster recovery efforts, but could also be 
used for initial data migrations or other scenarios where users would like to 
deploy this chart with existing CouchDB data.
   
   #### Which issue this PR fixes
   No related issue tracker.
   
   #### Special notes for your reviewer:
   * I noticed [my previous merged 
PR](https://github.com/apache/couchdb-helm/pull/102)'s version bump isn't being 
listed by `helm search repo` for the `https://apache.github.io/couchdb-helm` 
repo, but it _does_ appear to be listed on [the releases page](url) for this 
project on github.com.  Not sure if there's something I'm doing wrong or 
something needs to be fixed.
   * I'm still getting the error I got from my previous PR running `make test`.
   
          Error: Error linting and installing charts: Error identifying merge 
base: Error running process: exit status 128
   
     This seems like an unrelated/existing issue, but please let me know if I'm 
doing something wrong here, as well.
   
   #### Checklist
   [Place an '[x]' (no spaces) in all applicable fields. Please remove 
unrelated fields.
   - [x] Chart Version bumped
   - [ ] e2e tests pass
   - [x] Variables are documented in the README.md
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to