nickva commented on code in PR #4370:
URL: https://github.com/apache/couchdb/pull/4370#discussion_r1068417710
##########
src/couch_replicator/src/couch_replicator_worker.erl:
##########
@@ -349,8 +349,9 @@ bulk_get(#httpdb{} = Source, #{} = IdRevs) ->
case couch_replicator_api_wrap:bulk_get(Source, IdRevs, Opts) of
{ok, #{} = Docs} ->
FilterFun = fun
- (_, #doc{atts = []}) -> true;
+ (_, #doc{id = <<?DESIGN_DOC_PREFIX, _/binary>>}) -> false;
Review Comment:
I see minor optimization here - since we know right off the bat these are
design documents, we don't have to fetch them in bulk_get at all (unlike the
ones with attachments). So am thinking of updating to fetch and upload design
docs, fetch the bulk docs, do the attachments ones. What do we think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
