nickva commented on code in PR #4401: URL: https://github.com/apache/couchdb/pull/4401#discussion_r1084801828
########## src/chttpd/test/eunit/chttpd_changes_test.erl: ########## @@ -0,0 +1,663 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); you may not +% use this file except in compliance with the License. You may obtain a copy of +% the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, software +% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +% License for the specific language governing permissions and limitations under +% the License. + +-module(chttpd_changes_test). + +-include_lib("couch/include/couch_db.hrl"). +-include_lib("couch/include/couch_eunit.hrl"). + +-define(USER, "chttpd_changes_test_admin"). +-define(PASS, "pass"). +-define(AUTH, {basic_auth, {?USER, ?PASS}}). +-define(JSON, {"Content-Type", "application/json"}). + +-define(DOC1, <<"doc1">>). +-define(DDC2, <<"_design/doc2">>). +-define(DOC3, <<"doc3">>). +-define(REVA, <<"a">>). +-define(REVB, <<"b">>). +-define(REVC, <<"c">>). +-define(DELETED, true). +-define(LEAFREV, false). + +% doc1 starts as rev-a, then gets 2 conflicting revisions b and c +% ddoc2 starts as deleted at rev-a, then gets re-created as rev-c +% doc3 starts as rev-a, then gets deleted as rev-c +% +test_docs() -> + [ + {?DOC1, [?REVA], ?LEAFREV}, + {?DDC2, [?REVA], ?DELETED}, + {?DOC3, [?REVA], ?LEAFREV}, + {?DOC1, [?REVB, ?REVA], ?LEAFREV}, + {?DOC1, [?REVC, ?REVA], ?LEAFREV}, + {?DOC3, [?REVB, ?REVA], ?DELETED}, + {?DDC2, [?REVC, ?REVA], ?LEAFREV} + ]. + +% Thesa are run against a Q=1, N=1 db, so we can make +% some stronger assumptions about the exact Seq prefixes +% returned sequences will have +% +changes_test_() -> + { + setup, + fun setup_basic/0, + fun teardown_basic/1, + with([ + ?TDEF(t_basic), + ?TDEF(t_basic_post), + ?TDEF(t_continuous), + ?TDEF(t_continuous_zero_timeout), + ?TDEF(t_longpoll), + ?TDEF(t_limit_zero), + ?TDEF(t_continuous_limit_zero), + ?TDEF(t_limit_one), + ?TDEF(t_since_now), + ?TDEF(t_continuous_since_now), + ?TDEF(t_longpoll_since_now), + ?TDEF(t_style_all_docs), + ?TDEF(t_reverse), + ?TDEF(t_continuous_reverse), + ?TDEF(t_reverse_limit_zero), + ?TDEF(t_reverse_limit_one), + ?TDEF(t_seq_interval), + ?TDEF(t_selector_filter), + ?TDEF(t_design_filter), + ?TDEF(t_docs_id_filter), + ?TDEF(t_docs_id_filter_over_limit) + ]) + }. + +% For Q=8 sharded dbs, unlike Q=1, we cannot make strong +% assumptions about the exact sequence IDs for each row +% so we'll test all the changes return and that the sequences +% are increasing. +% +changes_q8_test_() -> + { + setup, + fun setup_q8/0, + fun teardown_basic/1, + with([ + ?TDEF(t_basic_q8), + ?TDEF(t_continuous_q8), + ?TDEF(t_limit_zero), + ?TDEF(t_limit_one_q8), + ?TDEF(t_since_now), + ?TDEF(t_longpoll_since_now), + ?TDEF(t_reverse_q8), + ?TDEF(t_reverse_limit_zero), + ?TDEF(t_reverse_limit_one_q8), + ?TDEF(t_selector_filter), + ?TDEF(t_design_filter), + ?TDEF(t_docs_id_filter_q8) + ]) + }. + +% These tests are separate as they create aditional design docs +% as they so technically would be order dependent as the sequence Review Comment: Good catch, I didn't explain that very well. I'll update the comment. The idea is that the filter design docs are added to the database during the test execution. Each time that happens the last update sequence gets bumped by 1. If we check last_seq being 8, for instance, the next test might need to assert 10 and so on. Now order is deterministic currently, it might look confusing and would prevent inserting a test in the middle somewhere as well. To avoid that, these tests were moved to a separate suite and the setup/teardown run for each individual test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
