ckruse opened a new pull request, #4432: URL: https://github.com/apache/couchdb/pull/4432
It hides the shard-sync and purge documents from the response unless a `?include_system=true` is given. ## Overview Currently the system docs are included in `_local_docs`. This has shown to confuse users, and they try to delete them, which might fail and/or lead to problems. ## Testing recommendations ``` curl -X PUT http://admin:[email protected]:15984/test-db curl -X PUT http://admin:[email protected]:15984/test-db/doc -d '{"a":1}' curl -X POST http://admin:[email protected]:15984/test-db/_purge -d '{"doc":["1-23202479633c2b380f79507a776743d5"]}' -Hcontent-type:application/json sleep 5 # this shouldn't include any system documents curl http://admin:[email protected]:15984/test-db/_local_docs # this should include the system documents curl http://admin:[email protected]:15984/test-db/_local_docs?include_system=true ``` ## Related Issues or Pull Requests - #3930 ## Checklist I think most of this is not applicable. Regarding tests, I'm not sure if there should be added tests for this. It would mean a sleep in a test, wouldn't it? - [x] Code is written and works correctly - [ ] Changes are covered by tests - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini` - [ ] Documentation changes were made in the `src/docs` folder - [ ] Documentation changes were backported (separated PR) to affected branches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
