nickva commented on code in PR #4443: URL: https://github.com/apache/couchdb/pull/4443#discussion_r1117571061
########## src/couch/src/couch_hash.erl: ########## @@ -31,15 +31,27 @@ md5_hash_update(Context, Data) -> -else. md5_hash(Data) -> - crypto:hash(md5, Data). + case config:is_enabled(fips_mode) of Review Comment: For fips mode feature toggle. We'd have to make sure we set it as early as possible. It turns out some couch_epi code uses hashes early. So we may have to move that to config's init -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
