KangTheTerrible opened a new pull request, #4447:
URL: https://github.com/apache/couchdb/pull/4447

   ## Overview
   
   While investigating issues in my deployment around logrotate I discovered 
the file logger last_check doesn't appear to be updated after init is called, 
this could result in maybe_reopen being called with every log write 30 seconds 
after init is called. The fix works as the documentation specifies, but I 
wasn't able to measure a meaningful performance harm from the previous 
functionality. Throwing it up in case it's desirable.
   
   ## Testing recommendations
   
   With the fix observe it can take up to 30 seconds from the last check before 
the log is recreated after deletion. Without the fix the log gets recreated 
much more quickly.
   
   ## Related Issues or Pull Requests
   
   ## Checklist
   
   - [ ] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in 
`rel/overlay/etc/default.ini`
   - [ ] Documentation changes were made in the `src/docs` folder
   - [ ] Documentation changes were backported (separated PR) to affected 
branches
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to