nickva opened a new pull request, #4477: URL: https://github.com/apache/couchdb/pull/4477
There are a few minor improvements: - Add more tests to check sandboxing resets, and that docs are "frozen". - Remove the extra `\n` and `"` around function body lines. Erlang can do multi-line binaries just fine. Mark the sections with %erlfmt-ignore to the formatter doesn't complain. - Generalize `should_create_sandbox` test to check for the `not defined` string only. Experimenting with QuickJS noticed that it uses single quotes around`'Object.foo' is not defined` and SM doesn't. So check for `not defined` part only as it's obvious enough what the check is about. - Make sure to return test procs back to the pool. Previously, none of the tests returned the processes back into the pool, and when the tests ended, they were forcibly killed which resulted in log noise that looked like: ``` erl_child_setup: failed with error 32 on line 265 erl_child_setup: failed with error 32 on line 265 ... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
