chewbranca commented on code in PR #4483:
URL: https://github.com/apache/couchdb/pull/4483#discussion_r1149888067
##########
src/mango/src/mango_execution_stats.erl:
##########
@@ -35,6 +37,15 @@ to_json(Stats) ->
{execution_time_ms, Stats#execution_stats.executionTimeMs}
]}.
+to_map(Stats) ->
Review Comment:
Yeah... I thought about making shorter versions of the names, but those are
the names as they are in the codebase, and gzip'ed log rotation reduces the
impact of field length. I think more importantly though, we've already
introduced those names into the public API as documented in the `Execution
Statistics` portion of the `_find` documentation [1] and so I think it makes
sense to stay consistent with those, or at the very least, we should update
those as well if we're going to make shorter names here.
[1] https://docs.couchdb.org/en/stable/api/database/find.html#find-statistics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
