pgj commented on PR #4657: URL: https://github.com/apache/couchdb/pull/4657#issuecomment-1615194313
> The test is failing because the order of the elements changes. So we should at least fix that part. Sorry, I was answering the part about the statement that prepending with fold left reverses the order. You are right that the ordering does not matter in this case. But replacing this with a `map` breaks the unit tests. I did not notice that one, but I have pushed a fix for that since then. > We were not losing elements here either, they were pre-pended to the accumulator list. The only visible difference is that we ended up with a different order of elements. Ah, my concern is not the final result but the readability mainly. It acts like a map, why not to use the `map` function here? This is made evident. I believe such minor details could contribute to the overall understanding of the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
