willholley opened a new pull request, #127: URL: https://github.com/apache/couchdb-helm/pull/127
<!-- Thank you for contributing to couchdb-helm. Before you submit this PR we'd like to make sure you are aware of the chart technical requirements and best practices: * https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements * https://github.com/helm/helm/tree/master/docs/chart_best_practices For a quick overview across what we will look at reviewing your PR, please read our review guidelines: * https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md Following our best practices right from the start will accelerate the review process and help get your PR merged quicker. When updates to your PR are requested, please add new commits and do not squash the history. This will make it easier to identify new changes. The PR will be squashed anyways when it is merged. Thanks. Please make sure you test your changes before you push them. --> #### What this PR does / why we need it: If a large integer is specifed in values.yaml, it is parsed by Helm as a float64. For example: ``` couchdbConfig: chttpd: timeout: 5184000 ``` If this is converted to a string, it produces `5.184e+06` instead of the expected `5184000`. Given we never expect floats to be specified as configuration values to CouchDB, we can workaround this erroneus type conversion by casting the float64 back to an integer when rendering the ini file. This then correctly outputs: ``` inifile: | [chttpd] timeout = 5184000 ``` Note this will break any genuine uses of float64 types in the configuration, though I can't think of any cases where this would be valid. #### Which issue this PR fixes *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)* - fixes # #### Special notes for your reviewer: #### Checklist [Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields. - [ ] Chart Version bumped - [ ] e2e tests pass - [ ] Variables are documented in the README.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
