jaydoane commented on code in PR #4673:
URL: https://github.com/apache/couchdb/pull/4673#discussion_r1283833503
##########
src/couch/src/couch_db.erl:
##########
@@ -302,17 +313,26 @@ open_doc(Db, Id, Options) ->
{ok, #doc{deleted = true} = Doc} ->
case lists:member(deleted, Options) of
true ->
- apply_open_options({ok, Doc}, Options);
+ {ok, Doc};
false ->
{not_found, deleted}
end;
Else ->
- apply_open_options(Else, Options)
+ Else
end.
-apply_open_options({ok, Doc}, Options) ->
+apply_open_options(Db, Options) ->
Review Comment:
Seeing this compiler warning:
```
src/couch/src/couch_db.erl:324:1: Warning: function apply_open_options/2 is
unused
```
##########
src/couch/src/couch_db.erl:
##########
@@ -1666,6 +1815,12 @@ open_read_stream(Db, AttState) ->
is_active_stream(Db, StreamEngine) ->
couch_db_engine:is_active_stream(Db, StreamEngine).
+changes_since(Db, StartSeq, Fun, Options, Acc) when is_record(Db, db) ->
Review Comment:
Seeing this compiler warning:
```
src/couch/src/couch_db.erl:1818:1: Warning: function changes_since/5 is
unused
```
##########
src/couch/src/couch_db.erl:
##########
@@ -137,6 +140,8 @@
]).
-include_lib("couch/include/couch_db.hrl").
+% TODO: can we do without this?
+-include_lib("couch_mrview/include/couch_mrview.hrl").
Review Comment:
According to emacs lsp mode, yes you can remove it.
##########
src/couch/src/couch_db.erl:
##########
@@ -1307,6 +1392,36 @@ doc_tag(#doc{meta = Meta}) ->
Else -> throw({invalid_doc_tag, Else})
end.
+validate_update(Db, Doc) ->
+ case catch validate_access(Db, Doc) of
+ ok -> Doc;
+ Error -> Error
+ end.
+
+validate_docs_access(Db, DocBuckets, DocErrors) ->
+ validate_docs_access1(Db, DocBuckets, {[], DocErrors}).
+
+validate_docs_access1(_Db, [], {DocBuckets0, DocErrors}) ->
Review Comment:
Seeing this compiler warning:
```
src/couch/src/couch_db.erl:1404:1: Warning: function validate_docs_access1/3
is unused
```
##########
src/couch/src/couch_db.erl:
##########
@@ -1307,6 +1392,36 @@ doc_tag(#doc{meta = Meta}) ->
Else -> throw({invalid_doc_tag, Else})
end.
+validate_update(Db, Doc) ->
+ case catch validate_access(Db, Doc) of
+ ok -> Doc;
+ Error -> Error
+ end.
+
+validate_docs_access(Db, DocBuckets, DocErrors) ->
Review Comment:
Seeing this compiler warning:
```
src/couch/src/couch_db.erl:1401:1: Warning: function validate_docs_access/3
is unused
```
##########
src/couch/src/couch_db.erl:
##########
@@ -1307,6 +1392,36 @@ doc_tag(#doc{meta = Meta}) ->
Else -> throw({invalid_doc_tag, Else})
end.
+validate_update(Db, Doc) ->
Review Comment:
Seeing this compiler warning:
```
src/couch/src/couch_db.erl:1395:1: Warning: function validate_update/2 is
unused
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
