rnewson commented on code in PR #4445:
URL: https://github.com/apache/couchdb/pull/4445#discussion_r1299939816


##########
rel/overlay/etc/vm.args:
##########
@@ -38,8 +38,7 @@
 {{node_name}}
 
 # All nodes must share the same magic cookie for distributed Erlang to work.
-# Uncomment the following line and append a securely generated random value.
-# -setcookie
+{{erlang_cookie}}

Review Comment:
   The package scripts should be (_needs to be_) robust against this kind of 
thing and I believe they are.
   
   If the commented-out setcookie line is no longer present after this change 
the packaging scripts will append a setcookie line to the end of the file. 
That's less tidy than it being where we planned for it to be, but it will still 
work.
   
   I would, however, prefer for this change not to have unintended side-effects 
at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to