nickva commented on PR #4736:
URL: https://github.com/apache/couchdb/pull/4736#issuecomment-1692072177

   Testing with a local TLS listening socket:
   
   With a patch to block _all_docs:
   
   ```diff
   diff --git a/src/fabric/src/fabric_view_all_docs.erl 
b/src/fabric/src/fabric_view_all_docs.erl
   index a6786bff7..b0bbdaf5a 100644
   --- a/src/fabric/src/fabric_view_all_docs.erl
   +++ b/src/fabric/src/fabric_view_all_docs.erl
   @@ -263,6 +263,8 @@ handle_message(#view_row{} = Row, {Worker, From}, State) 
->
        Rows = merge_row(Dir, Row#view_row{worker = {Worker, From}}, Rows0),
        Counters1 = fabric_dict:update_counter(Worker, 1, Counters0),
        State1 = State#collector{rows = Rows, counters = Counters1},
   +    couch_log:error(" +++sleeping before sending row++++ ~p:~p@~B~p", 
[?MODULE, ?FUNCTION_NAME, ?LINE, Row]),
   +    timer:sleep(60000),
        fabric_view:maybe_send_row(State1);
   ```
   
   I see the expected log line:
   ```
   [warning] 2023-08-24T16:40:44.677817Z [email protected] <0.2203.0> -------- 
client socket 
{ssl,{sslsocket,{gen_tcp,#Port<0.18>,tls_connection,[{option_tracker,<0.636.0>},{session_tickets_tracker,disabled},{session_id_tracker,<0.637.0>}]},[<0.2191.0>,<0.2190.0>]}}
 disconnected, terminating <0.2061.0>
   ```
   
   That seems too verbose so after discussing with @rnewson we figured we 
should remove the log line altogether.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to