nickva commented on PR #4782: URL: https://github.com/apache/couchdb/pull/4782#issuecomment-1746978799
It does seem wrong to update the bookmark with the duplicate IDs. We're effectively getting index results from a newer database snapshot than the one we opened in the request (the index got ahead of the database, so to speak). So, we wouldn't want to update the bookmark or do anything with the duplicate IDs except just ignore them. If we reworked these indexes to store document IDs and update sequences, when we read those documents we would check that `IndexSeq =< DbSeq` and discard anything else. Then we wouldn't need to accumulate a `Seen` set. That however, is a larger rewrite with possibly backward compatibility implications. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
