nickva commented on code in PR #4791:
URL: https://github.com/apache/couchdb/pull/4791#discussion_r1346159273
##########
nouveau/src/main/java/org/apache/couchdb/nouveau/core/IndexManager.java:
##########
@@ -97,7 +97,7 @@ public <R> R with(final String name, final IndexLoader
loader, final IndexFuncti
throw (IOException) e.getCause();
}
- if (index.tryAcquire(1, TimeUnit.SECONDS)) {
+ if (index.tryAcquire()) {
Review Comment:
If we removed the timed `tryAcquire` do we still have to declare we catch
`InterruptedException`?
And then would we end up spinning in a loop if tryAcquire keeps returning a
`false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
