Antonio-Maranhao commented on code in PR #1415:
URL: https://github.com/apache/couchdb-fauxton/pull/1415#discussion_r1364693651
##########
app/addons/documents/mango/components/ExplainPage.js:
##########
@@ -23,10 +26,175 @@ export default class ExplainPage extends Component {
prettyPrint();
}
+ state = {
+ viewFormat: 'parsed',
+ isReasonsModalVisible: false,
Review Comment:
`viewFormat` must be part of the redux state (not local state). Ideally both
should be but I'm ok with the modal one being local since it's ok for it to
reset if the page reloads.
##########
app/addons/documents/mango/components/ExplainReasonsLegendModal.js:
##########
@@ -0,0 +1,65 @@
+import React from 'react';
+import { Modal, Table } from 'react-bootstrap';
+
+// const typeOpValidValues = `"null", "boolean", "number", "string", "array",
and "object"`;
Review Comment:
remove
##########
app/addons/documents/mango/components/ExplainReasonsLegendModal.js:
##########
@@ -0,0 +1,65 @@
+import React from 'react';
Review Comment:
missing the Legal disclaimer at the top
##########
app/addons/documents/assets/scss/mango-query.scss:
##########
@@ -61,3 +61,96 @@
}
}
}
+
+.explain-view-toggle {
+ margin-bottom: 1rem;
+}
+
+.explain-json-response {
+ padding-left: 0rem;
+ margin-top: 1rem;
+}
+
+.explain-plan-section-title {
+ font-size: 1rem;
+ i {
+ margin-left: 0.5rem;
+ }
+}
+
+.explain-reasons-legend-modal {
+ max-width: none!important;
+ width: 50%!important;
+
+ .table-wrapper {
+ max-height: 300px;
+ overflow-y: scroll;
+ }
+}
+
+.explain-index-panel {
+ background-color: white;
+ margin-left: 0.25rem !important;
+ margin-right: 0.25rem !important;
+ padding: 0.5rem;
+ border-top: 1px solid $cf-border-color01;
+ border-bottom: 1px solid $cf-border-color01;
+ word-break: break-all;
+ font-size: 0.875rem;
+
+ .index-ddoc-name {
+ font-size: 0.75rem;
+ }
+
+ .index-extra-info {
+ word-break: normal;
+ }
+
+ i.icon {
+ margin-left: 0.5rem;
+ }
+
+ ul.component-badgelist {
+ margin-bottom: 0;
+ margin-top: 0;
+ }
+
+ li.badge {
+ margin-left: 0;
+ padding-left: 0;
+
+ div.remove-filter {
+ padding: 0.5rem;
+ background-color: #d0e2ff;
Review Comment:
No literals for colors. You must pick a SCSS variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
