pgj commented on code in PR #4984:
URL: https://github.com/apache/couchdb/pull/4984#discussion_r1495068510
##########
src/fabric/src/fabric_view.erl:
##########
@@ -187,23 +187,33 @@ possibly_embed_doc(
#view_row{id = reduced} = Row
) ->
Row;
+possibly_embed_doc(
+ _State,
+ #{id := reduced} = Row
+) ->
+ Row;
possibly_embed_doc(
_State,
#view_row{value = undefined} = Row
) ->
Row;
Review Comment:
I think this was originally added here to implement a shortcut. But since
keys with `undefined` value are not stored in the map representation, the same
cannot be realized in that case so it will go through the code path as you
suggested. I do not think this line should be removed for now but along with
retiring the `#view_row{}` record.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
