nickva commented on code in PR #5014:
URL: https://github.com/apache/couchdb/pull/5014#discussion_r1556238351
##########
rel/overlay/etc/default.ini:
##########
@@ -930,3 +930,99 @@ url = {{nouveau_url}}
;max_objects = 10000
;max_idle = 600000
;enable = true
+
+[couch_scanner]
+; How often to check for configuration changes and start/stop plugins
+;interval_sec = 5
+
+; Minimum time to force a plugin to wait before running again after a crash
+;min_penalty_sec = 30
+
+; Maximum time to force a plugin to wait after repeated crashes (8 hours
default)
+;max_penalty_sec = 28800
+
+; If plugin runs successfully without crashing for this long, reset its
+; repeated error count
+;heal_threshold_sec = 300
+
+; Database processing rate limit per second. This will also be the
+; rate at which design documents are fetched. The rate is shared
+; across all running plugins.
Review Comment:
Currently the rate limiter bucket refill period is driven by the
`couch_scanner_server` interval period (= 5 second) so we fill the bucket with
the "5 seconds worth of tokens", that provides some batching and allows
bursting for a bit, but also wonder if it's too much bursting and maybe a
dedicated rate limiter gen_server refilling the bucket every 1 or 2 seconds
would be better and then the interval in couch_scanner_server can be increased
as it's not tied to the rate limiter (it can 10-15 seconds or so).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
