janl commented on code in PR #5021:
URL: https://github.com/apache/couchdb/pull/5021#discussion_r1559345031
##########
test/elixir/test/nouveau_test.exs:
##########
@@ -75,23 +75,20 @@ defmodule NouveauTest do
assert resp.status_code in [201]
end
- def create_ddoc(db_name, opts \\ %{}) do
- default_ddoc = %{
+ def create_ddoc(db_name, ddoc \\
+ %{
nouveau: %{
bar: %{
default_analyzer: "standard",
index: """
- function (doc) {
- index("string", "foo", doc.foo, {store: true});
- index("double", "bar", doc.bar, {store: true});
- }
+ function (doc) {
+ index("string", "foo", doc.foo, {store: true});
+ index("double", "bar", doc.bar, {store: true});
+ }
Review Comment:
whitespace only change, is this needed at all?
##########
src/docs/src/ddocs/nouveau.rst:
##########
@@ -94,6 +94,10 @@ Stored
analysis. The value is returned with search results but you cannot search,
sort, range or facet over a stored field.
+.. warning:: the type of any specific field is determined by the first index
+ call. Attempts to index a different type into the same field will
+ throw an exception and the document will not be indexed at all.
Review Comment:
this sounds like you are going with current view behaviour and not “make the
index build fail until fixed”? it seems to be contradicted by
https://github.com/apache/couchdb/pull/5021/files#diff-0acc2e900aa87893a10652317d70fb417c158bb86e75a9b94f19767eba0d0c92R622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
